FIX: support [code] in blockquotes #26182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> [code] > line1 > line2 > [/code] would render as | line1 | > line2 instead of the correct | line1 | line2 That was due to the `bbcode-block` code using a `slice` to get the content of a block and not taking into account it being nested in a quote block for example. The fix was to get the content using the `getLines` utils method. Context: https://meta.discourse.org/t/markdown-bbcode-code-quote-bug/299047
ZogStriP
commented
Mar 14, 2024
| state.bMarks[startLine + 1], | ||
| state.eMarks[nextLine - 1] | ||
| ); | ||
| content = state.getLines(startLine + 1, nextLine, 0, false); |
There was a problem hiding this comment.
This line is the actual bug fix. Doing a start.src.slice was not taking into account being nested inside a block quote for example (which prepends a > on every line).
The getLines function does all the heavy lifting for us 👏
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/markdown-bbcode-code-quote-bug/299047/9 |
CvX
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
would render as
| line1
| > line2
instead of the correct
| line1
| line2
That was due to the
bbcode-blockcode using asliceto get the content of a block and not taking into account it being nested in a quote block for example.The fix was to get the content using the
getLinesutils method.Context: https://meta.discourse.org/t/markdown-bbcode-code-quote-bug/299047